Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic and interval when do not have keyword interval #5339

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: panic and interval when do not have keyword interval #5339

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38bebbc
fix: panic and interval when do not have keyword
yihong0618 Jan 10, 2025
955e4fa
fix: wrong pos...
yihong0618 Jan 10, 2025
73d6e41
Merge branch 'main' into hy/fix_panic_on_interval
yihong0618 Jan 10, 2025
8f9370c
Merge branch 'main' into hy/fix_panic_on_interval
yihong0618 Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/sql/src/statements.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,15 @@ pub fn sql_value_to_value(
(*b).into()
}
SqlValue::DoubleQuotedString(s) | SqlValue::SingleQuotedString(s) => {
// ensure data_type is not interval type when parsing string
ensure!(
!matches!(data_type, ConcreteDataType::Interval(_)),
ColumnTypeMismatchSnafu {
column_name,
expect: data_type.clone(),
actual: ConcreteDataType::string_datatype(),
}
);
parse_string_to_value(column_name, s.clone(), data_type, timezone)?
}
SqlValue::HexStringLiteral(s) => {
Expand Down
Loading