feat: support add if not exists in the gRPC alter kind #5273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* checks in make_region_alter_kind() * reuse the alter kind
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
evenyag
requested review from
v0y4g3r,
MichaelScofield,
waynexia and
a team
as code owners
2 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5273 +/- ##
==========================================
- Coverage 83.93% 83.86% -0.07%
==========================================
Files 1203 1199 -4
Lines 224144 224559 +415
==========================================
+ Hits 188125 188331 +206
- Misses 36019 36228 +209 |
v0y4g3r
approved these changes
Jan 3, 2025
This PR doesn't change the behavior so we don't have to update it. |
evenyag
added a commit
to evenyag/greptimedb
that referenced
this pull request
Jan 3, 2025
…5273) * test: test adding existing columns * chore: add more checks to AlterKind * chore: update logs * fix: check and build table info first * feat: Add add_if_not_exists flag to alter expr * feat: skip existing columns when building alter kind * checks in make_region_alter_kind() * reuse the alter kind * test: fix tests in common-meta * chore: fix typos * chore: update comments
This was referenced Jan 3, 2025
evenyag
added a commit
to evenyag/greptimedb
that referenced
this pull request
Jan 3, 2025
…5273) * test: test adding existing columns * chore: add more checks to AlterKind * chore: update logs * fix: check and build table info first * feat: Add add_if_not_exists flag to alter expr * feat: skip existing columns when building alter kind * checks in make_region_alter_kind() * reuse the alter kind * test: fix tests in common-meta * chore: fix typos * chore: update comments
evenyag
added a commit
that referenced
this pull request
Jan 3, 2025
* test: test adding existing columns * chore: add more checks to AlterKind * chore: update logs * fix: check and build table info first * feat: Add add_if_not_exists flag to alter expr * feat: skip existing columns when building alter kind * checks in make_region_alter_kind() * reuse the alter kind * test: fix tests in common-meta * chore: fix typos * chore: update comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
add_if_not_existstoAddColumngreptime-proto#207What's changed and what's your intention?
This PR adds the
add_if_not_existsflag to the AddColumn alter kind and validates the alteration to the table in the prepare step of the AlterTableProcedure. Before this PR, the procedure may not be able to build table info in the update metadata step, which causes regions to have an inconsistent schema with the meta server.It also fixes an issue that the procedure always alters tables without
add_if_not_existswhich is different from the behavior of auto alteration.PR Checklist
Please convert it to a draft if some of the following conditions are not met.