-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): make table name of pg backend configurable #5244
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5244 +/- ##
==========================================
- Coverage 84.15% 83.89% -0.27%
==========================================
Files 1200 1202 +2
Lines 225386 226081 +695
==========================================
- Hits 189682 189673 -9
- Misses 35704 36408 +704 |
ee5b93f
to
df47f1a
Compare
Updated with |
867f134
to
eb5f268
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
@CookiePieWw Lots of conflicts. |
eb5f268
to
dcbec3d
Compare
Rewrite with both configurable lock id and meta table name. PTAL @killme2008 @WenyXu @fengjiachun |
Co-authored-by: Weny Xu <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#5208
What's changed and what's your intention?
As title. I init a separate config, but seems it's better to place the table name under the previous kvbackend config?
PR Checklist
Please convert it to a draft if some of the following conditions are not met.