feat(flow): check sink table mismatch on flow creation #5112

discord9 · 2024-12-06T12:07:50Z

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

check sink table mismatch on flow creation

Please explain IN DETAIL what the changes are in this PR and why they are needed:

on flow creation, if sink table exist, check if schema's datatype is mismatched
if sink table not exist when creating flow, create sink table with inferred schema

Checklist

I have written the necessary rustdoc comments.
I have added the necessary unit tests and integration tests.
This PR requires documentation updates.

coderabbitai · 2024-12-06T12:07:57Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-12-12T08:44:22Z

Codecov Report

Attention: Patch coverage is 6.13718% with 260 lines in your changes missing coverage. Please review.

Project coverage is 83.80%. Comparing base (4051be4) to head (bc7f28d).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5112      +/-   ##
==========================================
- Coverage   84.08%   83.80%   -0.29%     
==========================================
  Files        1193     1194       +1     
  Lines      221268   221415     +147     
==========================================
- Hits       186047   185550     -497     
- Misses      35221    35865     +644

tests/cases/standalone/common/flow/flow_basic.sql

src/common/error/src/lib.rs

Copilot reviewed 8 out of 23 changed files in this pull request and generated no comments.

Files not reviewed (15)

tests/cases/standalone/common/flow/flow_auto_sink_table.result: Language not supported
tests/cases/standalone/common/flow/flow_auto_sink_table.sql: Language not supported
tests/cases/standalone/common/flow/flow_basic.sql: Language not supported
tests/cases/standalone/common/flow/show_create_flow.result: Language not supported
src/flow/src/error.rs: Evaluated as low risk
src/flow/src/server.rs: Evaluated as low risk
src/flow/src/adapter/util.rs: Evaluated as low risk
src/flow/src/repr/relation.rs: Evaluated as low risk
src/flow/src/adapter.rs: Evaluated as low risk
src/flow/src/adapter/node_context.rs: Evaluated as low risk
src/flow/src/adapter/table_source.rs: Evaluated as low risk
src/operator/src/insert.rs: Evaluated as low risk
src/servers/src/http/result/error_result.rs: Evaluated as low risk
src/operator/src/expr_factory.rs: Evaluated as low risk
Cargo.toml: Evaluated as low risk

tests/cases/standalone/common/flow/flow_auto_sink_table.sql

killme2008 · 2024-12-18T03:05:46Z

Changing the status and code header will result in many SQL tests failing due to the modified error message.

Focus on your needs rather than altering the underlying code.

@discord9

killme2008 · 2024-12-18T03:07:24Z

As you can see the results in https://github.com/GreptimeTeam/greptimedb/actions/runs/12377853661/job/34548598017?pr=5112

killme2008 · 2024-12-18T03:18:25Z

We don't need to send the stack trace to the frontend; users only require the root cause message and the error code. For further investigation, the stack trace and detailed error information can be found in the data nodes or flow nodes.

discord9 · 2024-12-18T04:04:42Z

revert back those commit and not use typed header for now and separate to another PR once this is merged

fengjiachun

Rest LGTM

…5112) * tests: more mismatch errors * feat: check sink table schema if exists&prompt nice err msg * chore: rm unused variant * chore: fmt * chore: cargo clippy * feat: check schema on create * feat: better err msg when mismatch * tests: fix a schema mismatch * todo: create sink table * feat: create sink table * fix: find time index * tests: auto created sink table * fix: remove empty keys * refactor: per review * chore: fmt * test: sqlness * chore: after rebase

* tests: more mismatch errors * feat: check sink table schema if exists&prompt nice err msg * chore: rm unused variant * chore: fmt * chore: cargo clippy * feat: check schema on create * feat: better err msg when mismatch * tests: fix a schema mismatch * todo: create sink table * feat: create sink table * fix: find time index * tests: auto created sink table * fix: remove empty keys * refactor: per review * chore: fmt * test: sqlness * chore: after rebase

github-actions bot added the docs-not-required This change does not impact docs. label Dec 6, 2024

discord9 force-pushed the flow_ck_mismatch_on_create branch from fde6f0a to a1e649b Compare December 11, 2024 12:06

discord9 marked this pull request as ready for review December 12, 2024 07:38

discord9 requested review from zhongzc, waynexia and a team as code owners December 12, 2024 07:38

discord9 requested review from shuiyisong and removed request for zhongzc December 12, 2024 07:39

evenyag requested a review from zhongzc December 16, 2024 07:19

evenyag added the A-flow Involves code in DataFlow label Dec 16, 2024

waynexia reviewed Dec 16, 2024

View reviewed changes

tests/cases/standalone/common/flow/flow_basic.sql Outdated Show resolved Hide resolved

src/common/error/src/lib.rs Outdated Show resolved Hide resolved

waynexia requested a review from Copilot December 16, 2024 10:12

Copilot AI reviewed Dec 16, 2024

View reviewed changes

fengjiachun reviewed Dec 17, 2024

View reviewed changes

tests/cases/standalone/common/flow/flow_auto_sink_table.sql Outdated Show resolved Hide resolved

discord9 requested a review from MichaelScofield as a code owner December 17, 2024 11:36

discord9 force-pushed the flow_ck_mismatch_on_create branch from 8fd9ab7 to 4f1ef27 Compare December 18, 2024 03:59

shuiyisong mentioned this pull request Dec 24, 2024

need more debug/trace log for flow troubleshoting #5226

Closed

discord9 force-pushed the flow_ck_mismatch_on_create branch from 4f1ef27 to 1ddaa7b Compare December 24, 2024 09:29

fengjiachun approved these changes Dec 25, 2024

View reviewed changes

discord9 added 5 commits December 25, 2024 19:21

tests: more mismatch errors

9f270c4

feat: check sink table schema if exists&prompt nice err msg

c6deb02

chore: rm unused variant

399ac1a

chore: fmt

16387fc

chore: cargo clippy

130f6bf

discord9 added 11 commits December 25, 2024 19:22

feat: check schema on create

23379bb

feat: better err msg when mismatch

0d33199

tests: fix a schema mismatch

2e5d594

todo: create sink table

9b07c2c

feat: create sink table

49ef157

fix: find time index

28d9774

tests: auto created sink table

83222e5

fix: remove empty keys

681e8ee

refactor: per review

162dc0a

chore: fmt

da5802e

test: sqlness

844674d

discord9 force-pushed the flow_ck_mismatch_on_create branch from f45f69b to 844674d Compare December 25, 2024 11:26

chore: after rebase

bc7f28d

waynexia approved these changes Dec 25, 2024

View reviewed changes

waynexia added this pull request to the merge queue Dec 25, 2024

Merged via the queue into GreptimeTeam:main with commit abf34b8 Dec 25, 2024
36 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(flow): check sink table mismatch on flow creation #5112

feat(flow): check sink table mismatch on flow creation #5112

discord9 commented Dec 6, 2024 •

edited

Loading

coderabbitai bot commented Dec 6, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Dec 12, 2024 •

edited

Loading

killme2008 commented Dec 18, 2024

killme2008 commented Dec 18, 2024

killme2008 commented Dec 18, 2024 •

edited

Loading

discord9 commented Dec 18, 2024

fengjiachun left a comment

feat(flow): check sink table mismatch on flow creation #5112

feat(flow): check sink table mismatch on flow creation #5112

Conversation

discord9 commented Dec 6, 2024 • edited Loading

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Checklist

coderabbitai bot commented Dec 6, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Dec 12, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

killme2008 commented Dec 18, 2024

killme2008 commented Dec 18, 2024

killme2008 commented Dec 18, 2024 • edited Loading

discord9 commented Dec 18, 2024

fengjiachun left a comment

Choose a reason for hiding this comment

discord9 commented Dec 6, 2024 •

edited

Loading

coderabbitai bot commented Dec 6, 2024 •

edited

Loading

codecov bot commented Dec 12, 2024 •

edited

Loading

killme2008 commented Dec 18, 2024 •

edited

Loading