-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: unify the execution of show stmt #1340
refactor: unify the execution of show stmt #1340
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1340 +/- ##
===========================================
- Coverage 85.96% 85.43% -0.54%
===========================================
Files 506 510 +4
Lines 76892 76836 -56
===========================================
- Hits 66103 65647 -456
- Misses 10789 11189 +400 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about unifying Statement
from SQL, EvalStmt
from PromQL, and LogicalPlan
together in QueryStatement
? Maybe TQL can also be part of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* refactor: unify the execution of show stmt
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
this PR unify the execution of show stmt of standalone and cluster to one place.
also write a document about how to implement statement in GreptimeDB. I think it helps understanding the codes.
Checklist
Refer to a related PR or issue link (optional)