Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify the execution of show stmt #1340

Merged

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

this PR unify the execution of show stmt of standalone and cluster to one place.

also write a document about how to implement statement in GreptimeDB. I think it helps understanding the codes.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #1340 (1f2eebf) into develop (f8b6a6b) will decrease coverage by 0.54%.
The diff coverage is 69.41%.

❗ Current head 1f2eebf differs from pull request most recent head 82775f9. Consider uploading reports for the commit 82775f9 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1340      +/-   ##
===========================================
- Coverage    85.96%   85.43%   -0.54%     
===========================================
  Files          506      510       +4     
  Lines        76892    76836      -56     
===========================================
- Hits         66103    65647     -456     
- Misses       10789    11189     +400     

Copy link
Member

@sunng87 sunng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/how-to/how-to-implement-sql-statement.md Outdated Show resolved Hide resolved
src/frontend/src/statement.rs Outdated Show resolved Hide resolved
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about unifying Statement from SQL, EvalStmt from PromQL, and LogicalPlan together in QueryStatement? Maybe TQL can also be part of it.

src/query/src/query_engine.rs Outdated Show resolved Hide resolved
src/frontend/src/statement.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield merged commit 33dbf72 into GreptimeTeam:develop Apr 12, 2023
@MichaelScofield MichaelScofield deleted the refactor/unify-show-stmt branch April 12, 2023 15:09
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* refactor: unify the execution of show stmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants