Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: table clustering/partitioning support. #2077

Merged

Conversation

shollyman
Copy link
Contributor

Intent here is to add support for specifying the column for
partitioned tables, allowing specification of secondary data
clustering, and enabling the ability to designate the ability
to disallow unbounded full table scans on large partitioned
tables via the requirePartitionFilter toggle.

Descriptions for these features were copied from BQ v2 discovery.

Disclaimer: While I'm familiar with the BQ API I'm very unfamiliar
with this tooling, so this may be a glorious example of holding the
tools wrong.

Release Note for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@shollyman
Copy link
Contributor Author

The other thing to consider is migrating require_partition_filter out of the existing time_partitioning submessage, but that's likely a breaking change and I don't know how that's handled in this ecosystem with respect to when such changes are allowed.

@slevenick slevenick requested a review from tysen August 6, 2019 19:23
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 61c61e0.

Pull request statuses

No diff detected in terraform-google-conversion.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1025
depends: hashicorp/terraform-provider-google#4223
depends: modular-magician/ansible#347
depends: modular-magician/inspec-gcp#179

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 027c81d.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

shollyman and others added 6 commits August 16, 2019 18:52
Intent here is to add support for specifying the column for
partitioned tables, allowing specification of secondary data
clustering, and enabling the ability to designate the ability
to disallow unbounded full table scans on large partitioned
tables.

That said, while I'm familiar with the BQ API I'm very unfamiliar
with this tooling, so this may be a glorious example of holding the
tools wrong.
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants