Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

Switching from format("%s-a", var.region) -> var.zone on bastion resource #4

Merged

Conversation

simonbutt
Copy link
Contributor

Switching from format(%s-a, var.region) -> var.zone on the bastion terraform resource. We already have zone as a variable and the previous doesn't work for the europe-west1 or us-east1 regions (which don't contain a "-a" zone)

Signed-off-by: simonbutt [email protected]

…rraform resource. We already have zone as a variable and the previous doesn't work for the europe-west1 or us-east1 regions

Signed-off-by: simonbutt <[email protected]>
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@simonbutt
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@kaariger kaariger merged commit a0c495f into GoogleCloudPlatform:master May 12, 2020
v1bh0r added a commit to v1bh0r/konga-gke that referenced this pull request Sep 28, 2020
Currently, the bastion health check assumes that the resource will only be deployed to zone 'a'.
Related to a similar PR - GoogleCloudPlatform#4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants