Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update urllib3 version #132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sharmaharisam
Copy link
Contributor

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sharmaharisam and reviewers,

I'm currently reviewing this pull request and will post my full review in a few minutes. In the meantime, here's a quick summary to help everyone get up to speed:

This PR updates the urllib3 dependency to version 2 or higher. The change is localized to the setup.py file, specifically lines 25-29. The previous version constraint (urllib3>=1.26.2,<2) is replaced with urllib3>=2. This likely addresses compatibility issues or incorporates security patches included in newer versions of urllib3. The intent, based on the PR title and description, is to resolve an issue (although the issue number is missing). I haven't been able to verify the tests yet, but I will do so as part of my full review.

Small changes, big impact,
Code's journey, a grand act.
Version bumps, a steady hand,
Keeping the system, safe and grand.

Thanks!

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates the urllib3 dependency to remove the upper bound. This change allows for more flexibility in urllib3 versions. It's crucial to thoroughly test this change with the intended environment and dependent libraries to ensure compatibility and avoid introducing vulnerabilities.

@@ -25,7 +25,7 @@
"requests>=2.25.1",
"ruamel.yaml>=0.17.7",
"six>=1.15.0",
"urllib3>=1.26.2,<2",
"urllib3>=2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While removing the upper bound allows flexibility, it's generally recommended to specify a version range to avoid potential issues with future, possibly incompatible urllib3 releases. Consider specifying an upper bound or a more precise version based on testing. For example, you could specify a compatible release or a range like urllib3>=2,<3, assuming major version 3 introduces breaking changes.

Suggested change
"urllib3>=2",
"urllib3>=2,<3"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant