Fetch missing one implementation from server #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fetches the data for missing one implementation chart from the server. Previously, it generated data on the client side. Other changes: - Modified playwright tests to use the same fake time on the stats page as the feature detail page. The previous fake time for the stats page, yields no results due to the short window of time that the [precalulation](https://github.com/GoogleChrome/webstatus.dev/blob/32fd24a5ea6131ddc4cb75912879e24731dcf939/util/cmd/load_fake_data/main.go#L410) of fake data happens. Future changes to consider: - Allow for configurable set of browsers instead of the hardcoded set.
jrobbins
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fetches the data for missing one implementation chart from the server. Previously, it generated data on the client side.
This change solves
Fetch "Missing One Implementation" counts from the backend APIon #838Other changes:
Future changes to consider: