Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(eslint): trailing commas for import/export #13059

Merged
merged 1 commit into from
Sep 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ module.exports = {
'comma-dangle': [2, {
arrays: 'always-multiline',
objects: 'always-multiline',
imports: 'never',
exports: 'never',
imports: 'always-multiline',
exports: 'always-multiline',
functions: 'never',
}],

Expand Down
2 changes: 1 addition & 1 deletion lighthouse-cli/test/fixtures/static-server.js
Original file line number Diff line number Diff line change
Expand Up @@ -260,5 +260,5 @@ if (esMain(import.meta)) {
export {
Server,
serverForOnline as server,
serverForOffline
serverForOffline,
};
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@ function updateTestDefnFormat(allTestDefns) {
}

export {
updateTestDefnFormat
updateTestDefnFormat,
};
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,5 @@ async function runLighthouse(url, configJson, testRunnerOptions = {}) {
}

export {
runLighthouse
runLighthouse,
};
2 changes: 1 addition & 1 deletion lighthouse-cli/test/smokehouse/lighthouse-runners/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,5 +146,5 @@ async function internalRun(url, tmpPath, configJson, options) {
}

export {
runLighthouse
runLighthouse,
};
2 changes: 1 addition & 1 deletion lighthouse-cli/test/smokehouse/smokehouse.js
Original file line number Diff line number Diff line change
Expand Up @@ -228,5 +228,5 @@ function getAssertionLog(count) {
}

export {
runSmokehouse
runSmokehouse,
};
Original file line number Diff line number Diff line change
Expand Up @@ -324,5 +324,5 @@ const gzip = {

export {
efficiency,
gzip
gzip,
};
Original file line number Diff line number Diff line change
Expand Up @@ -114,5 +114,5 @@ const blockAll = {
export {
allowAll,
blockAllM91,
blockAll
blockAll,
};
Original file line number Diff line number Diff line change
Expand Up @@ -105,5 +105,5 @@ const iframeBadSsl = {
export {
infiniteLoop,
expiredSsl,
iframeBadSsl
iframeBadSsl,
};
Original file line number Diff line number Diff line change
Expand Up @@ -151,5 +151,5 @@ export {
fetch,
xhr,
idleCallbackShort,
idleCallbackLong
idleCallbackLong,
};
Original file line number Diff line number Diff line change
Expand Up @@ -236,5 +236,5 @@ export {
onlineOnly,
ready,
swBroken,
swSlow
swSlow,
};
Original file line number Diff line number Diff line change
Expand Up @@ -141,5 +141,5 @@ const unsizedImages = {
export {
animations,
thirdParty,
unsizedImages
unsizedImages,
};
Original file line number Diff line number Diff line change
Expand Up @@ -389,5 +389,5 @@ export {
fonts,
debug,
traceElements,
frameMetrics
frameMetrics,
};
Original file line number Diff line number Diff line change
Expand Up @@ -117,5 +117,5 @@ const chromestatus = {

export {
airhorner,
chromestatus
chromestatus,
};
Original file line number Diff line number Diff line change
Expand Up @@ -123,5 +123,5 @@ const caltrain = {

export {
svgomg,
caltrain
caltrain,
};
Original file line number Diff line number Diff line change
Expand Up @@ -68,5 +68,5 @@ const pwarocks = {
};

export {
pwarocks
pwarocks,
};
Original file line number Diff line number Diff line change
Expand Up @@ -151,5 +151,5 @@ export {
multipleServer,
clientPaintServer,
singleClient,
historyPushState
historyPushState,
};
Original file line number Diff line number Diff line change
Expand Up @@ -483,5 +483,5 @@ export {
passing,
failing,
status403,
tapTargets
tapTargets,
};
Original file line number Diff line number Diff line change
Expand Up @@ -97,5 +97,5 @@ export {
trickyTtiLateFcp,
delayedLcp,
delayedFcp,
debuggerStatement
debuggerStatement,
};