core(lazy-lcp): fix failureTitle in lcp-lazy-loaded #13049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
requested review from
adamraine
and removed request for
a team
2 tasks
adamraine
approved these changes
Sep 13, 2021
|
@adamraine would you mind giving my descriptions/new titles one more pass? tests caught a few more missing titles |
adamraine
requested changes
Sep 13, 2021
| @@ -17,6 +17,10 @@ const URL = require('../../lib/url-shim.js'); | |||
| const i18n = require('../../lib/i18n/i18n.js'); | |||
|
|
|||
| const UIStrings = { | |||
| /** Descriptive title of a Lighthouse audit that checks if images match their displayed dimensions. This is displayed when the audit is passing. */ | |||
| title: 'Images were appropriate for their displayed size', | |||
There was a problem hiding this comment.
It's not ideal to duplicate the title, but it's the best way to get around this new check. Could we do a quick unit test to enforce these titles are the same?
There was a problem hiding this comment.
Oh they're explicitly not the same because one is an opportunity which uses imperative titles and this one is a descriptive title that has the binary flip.
This comment has been minimized.
This comment has been minimized.
|
Turns out I forgot to do a |
adamraine
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The failureTitle was defined in this audit but not actually exported on the
metadoh! This means the error message that the user receives is written backwards 😞We had validation for this to prevent such cases, but it only applied when the scoreDisplayMode was explicit, so this PR also fixes our validation to fail if the default scoreDisplayMode of binary is used.
Related Issues/PRs
Fixes #13048