report: make metric value more prominent in table #13036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
patrickhulce
and removed request for
a team
connorjclark
commented
Sep 9, 2021
| @@ -777,7 +791,7 @@ | |||
| flex: 1; | |||
| } | |||
|
|
|||
| .lh-metric .lh-metric__innerwrap::before, | |||
There was a problem hiding this comment.
using :before is hard to work with, so I made a new div for the icon
patrickhulce
approved these changes
Sep 9, 2021
| @@ -104,8 +104,8 @@ | |||
| --icon-square-size: calc(var(--score-icon-size) * 0.88); | |||
| --image-preview-size: 48px; | |||
| --metric-toggle-lines-fill: #7F7F7F; | |||
| --metric-value-font-size: 28px; | |||
There was a problem hiding this comment.
fwiw the mocks have 20/12 ratio which puts the target for 16px at ~26.6px
this looked fine to me though
Co-authored-by: Patrick Hulce <[email protected]>
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at tweaking the metrics table to new design. Just making the value bigger here, and shifting some of the grid stuff. Also, I tossed in a tweak to the mobile version.