v8.4.0 #13017
Merged
v8.4.0 #13017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
patrickhulce
and removed request for
a team
adamraine
approved these changes
Sep 7, 2021
changelog.md
Outdated
Comment on lines
51
to
55
| * flow: sidebar mocks ([#13002](https://github.com/GoogleChrome/lighthouse/pull/13002)) | ||
| * flow: embedded lighthouse report ([#12989](https://github.com/GoogleChrome/lighthouse/pull/12989)) | ||
| * flow: summary page ([#12973](https://github.com/GoogleChrome/lighthouse/pull/12973)) | ||
| * flow: navigation sidebar ([#12929](https://github.com/GoogleChrome/lighthouse/pull/12929)) | ||
| * flow: standalone shell report with preact ([#12850](https://github.com/GoogleChrome/lighthouse/pull/12850)) |
There was a problem hiding this comment.
Could put these under fraggle rock
patrickhulce
approved these changes
Sep 8, 2021
brendankenny
reviewed
Sep 8, 2021
changelog.md
Outdated
Comment on lines
52
to
53
| * isolate type checking ([#12953](https://github.com/GoogleChrome/lighthouse/pull/12953), [#12952](https://github.com/GoogleChrome/lighthouse/pull/12952), [#12951](https://github.com/GoogleChrome/lighthouse/pull/12951)) | ||
| * extract independent types ([#12946](https://github.com/GoogleChrome/lighthouse/pull/12946), [#12940](https://github.com/GoogleChrome/lighthouse/pull/12940)) |
There was a problem hiding this comment.
a lot of these aren't the report, maybe combine these (and #12914 under "Core") and make it "restructure types to use project references" (or something like that) and move to core or misc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.