Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(http-status-code): navigation only #13005

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Conversation

adamraine
Copy link
Member

It's the only (non-manual) audit in timespan SEO, and it would be N/A most of the time.

@adamraine adamraine requested a review from a team as a code owner September 2, 2021 20:22
@adamraine adamraine requested review from connorjclark and removed request for a team September 2, 2021 20:22
@google-cla google-cla bot added the cla: yes label Sep 2, 2021
@@ -130,7 +130,7 @@ describe('Fraggle Rock API', () => {
notApplicableAudits,
} = getAuditsBreakdown(lhr);
// TODO(FR-COMPAT): This assertion can be removed when full compatibility is reached.
expect(auditResults.length).toMatchInlineSnapshot(`50`);
expect(auditResults.length).toMatchInlineSnapshot(`48`);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual audit is filtered out automatically

@devtools-bot devtools-bot merged commit ce87060 into master Sep 2, 2021
@devtools-bot devtools-bot deleted the http-status-navigation branch September 2, 2021 20:45
satya-nutella pushed a commit to satya-nutella/lighthouse that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants