tests(ci): restore ToT Chromium download #12950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
requested review from
connorjclark
and removed request for
a team
Can we use |
we're down to 36 more |
|
connorjclark
approved these changes
Aug 20, 2021
yay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #12943
fixes #12942
Unfortunately for the
DevTools / integrationCI check, our clever method of only downloading the content-shell once a day:lighthouse/third-party/download-content-shell/download-content-shell.js
Lines 74 to 76 in 0b31fe2
currently is looking for downloads in the broken URL revision numbers and so will fail if the cached version isn't able to be used. It'll be about 90 more Chromium changes (starting with
913920) until we're clear of the broken revision numbers.