Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: format sample defaultPass.devtoolslog.json #12931

Closed
wants to merge 1 commit into from

Conversation

connorjclark
Copy link
Collaborator

trivial change to format this giant one-line json (using vscode json format), help somewhat with reviewing #12920 as I did the same there before manually tweaking some things.

truly, we ought to update this file wholesale, and maybe I'll give that a shot right now, but I don't think it'd be a quick endeavor.

@connorjclark connorjclark requested a review from a team as a code owner August 18, 2021 18:44
@connorjclark connorjclark requested review from adamraine and removed request for a team August 18, 2021 18:44
@google-cla google-cla bot added the cla: yes label Aug 18, 2021
@brendankenny
Copy link
Member

note that the JSON.stringify(devtoolsLog, null, 2) format is different than our current pretty-print format, which is an event per line (like the trace). See the format of defaultPass.devtoolslog.json in #12932 as an example.

@connorjclark
Copy link
Collaborator Author

connorjclark commented Aug 18, 2021

yes but ordering will change regardless across any wholeasale updates to this file (making diffs worthless), and there is no quick command AFAIK to take the current data and format it like that, so I figured this was fine.

@patrickhulce
Copy link
Collaborator

there is no quick command AFAIK to take the current data and format it like that

node ./lighthouse-core/scripts/lantern/minify-devtoolslog.js :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants