core: convert core d.ts files to modules #12880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Aug 7, 2021
| /** Errors preventing page being installable as PWA. This moved to a regular artifact in Fraggle Rock. */ | ||
| InstallabilityErrors: Artifacts.InstallabilityErrors; | ||
| /** A set of page-load traces, keyed by passName. */ | ||
| traces: {[passName: string]: LH.Trace}; |
There was a problem hiding this comment.
these remaining LH.* references are all in externd.d.ts, which is a real diverse grab bag of types :)
| } | ||
| // Result namespace | ||
| declare module Result { | ||
| interface Environment { |
There was a problem hiding this comment.
this moves LH.Environment to LH.Result.Environment, but the only reference to this type by name is in this file (on LH.Result['environment']), so it doesn't really matter. It just felt weird to be out on top with all the other subtypes already nested under LH.Result.
| artifacts?: Partial<Record<keyof LH.Artifacts|'_maxChromiumMilestone'|'_minChromiumMilestone', any>> | ||
| networkRequests?: {length: number}; | ||
| } | ||
| declare global { |
There was a problem hiding this comment.
this is equivalent to before (Smokehouse is a global type), but as soon the import lines were added above the file became a module, so it needed an explicit declare global
connorjclark
approved these changes
Aug 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #12860
in the style of #12870, converts all the rest of our core
.d.tsfiles to local import/export style with a single file for exposing on the global. No changes to js files here.externs.d.tsis the only remaining (core) file, left for a follow up because it's messier.No changes to
.jsfiles in this one.?w=1to avoid having to wade through all the indentation changes, and the individual file conversions (and their side effects) are split up by commit.