Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(page-functions): remove segfault workaround #12847

Merged
merged 1 commit into from
Aug 2, 2021
Merged

tests(page-functions): remove segfault workaround #12847

merged 1 commit into from
Aug 2, 2021

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark requested a review from a team as a code owner August 2, 2021 22:49
@connorjclark connorjclark requested review from adamraine and removed request for a team August 2, 2021 22:49
@google-cla google-cla bot added the cla: yes label Aug 2, 2021
adamraine
adamraine approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

brendankenny
brendankenny approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to assume @patrickhulce is good with the immediate and simple fix and we can discuss #12845 for future esm changes as #12689 continues

@brendankenny brendankenny merged commit bee8619 into master Aug 2, 2021
@brendankenny brendankenny deleted the pagefn-test-segf branch August 2, 2021 23:38
@connorjclark connorjclark mentioned this pull request Aug 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

@brendankenny brendankenny brendankenny approved these changes

Assignees

@adamraine adamraine

Labels
cla: yes waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connorjclark @brendankenny @adamraine @devtools-bot