misc: add prefix to lighthouse-logger debug scope #12806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
force-pushed
the
lh_logger_fix
branch
from
deec2bb to
84405ed
Compare
Chrome launcher too, unfortunately (unless that's what you were already referring to) |
I don't think we'll need that. Its version requirement is fairly loose, bumping our own yarn.lock should resolve to the same. |
|
Oh right, yes, carry on :) |
connorjclark
changed the title
connorjclark
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes our longstanding disrespect for other packages logging ;) Prefixes all of our log messages with
LH:so that it does not clobber the other prefixes using the same instance ofdebug(likepuppeteer).Will require immediate followup with a publish and version bump in our own deps.
Note that the impact of this is more limited than it appears because we are using an ancient debug, so most modern packages get their own instance :)
Related Issues/PRs
ref #12805 #11313