core(config): only allow lighthouse:default extension #11835
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes the loop on a few consequences @paulirish and I discussed of #11779. Breaking change to eventually allow extension of
lighthouse:mobile
andlighthouse:desktop
but make it clearer when yourextends
property is valid.Before
Any truthy value for a config's
extends
property would trigger extension of the default config.After
Any value other than
lighthouse:default
for a config'sextends
property throws a fatal error.Related Issues/PRs
ref #11779
#10910 (comment)