Skip to content

Commit

Permalink
drop todo on formfactor
Browse files Browse the repository at this point in the history
  • Loading branch information
paulirish committed Dec 15, 2020
1 parent 05917d1 commit 31a7b55
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion types/externs.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ declare global {
/** Flag indicating that the browser storage should not be reset for the audit. */
disableStorageReset?: boolean;

// TODO: formFactor should really be required, but since this type is shared in Flags, we can't reasonably do that. We'll likely need to separate SharedFlagsSettings into CLI Flags and Config Settings.
/** How Lighthouse should interpret this run in regards to scoring performance metrics and skipping mobile-only tests in desktop. Must be set even if throttling/emulation is being applied outside of Lighthouse. */
formFactor?: 'mobile'|'desktop';
/** Screen emulation properties (width, height, dpr, mobile viewport) to apply or an object of `{disabled: true}` if Lighthouse should avoid applying screen emulation. If either emulation is applied outside of Lighthouse, or it's being run on a mobile device, it typically should be set to disabled. For desktop, we recommend applying consistent desktop screen emulation. */
Expand Down

0 comments on commit 31a7b55

Please sign in to comment.