Add sponge block #531
Add sponge block #531
Conversation
|
How did I manage to compile an Iterator without the remove method is beyond my own comprehension. |
|
@socram8888 it's by default empty. (Java 8 default methods for interfaces) |
|
Incorrect drops for wet sponge. Also the naming of the iterator is kinda funny and doesn't seem to really apply to the definition of a taxicab number. I'm not sure on what else to call it though |
|
I called it TaxicabBlockIterator because in MinecraftWiki, it says that "A sponge absorbs water around itself (water source blocks or flowing water) out to a taxicab distance of 7 in all directions". I'm open to suggestions, though. |
|
Drops have been fixed. |
|
This fixes #498 sorry i couldn't resist |
|
This PR fails on edge cases. It also doesn't soak up the correct number of blocks. Edge case: |
|
That's how it's supposed to work, it will only scan if at least one face has water. That's why the wiki also says "taxicab", because it won't work for diagonals. |
|
This last PR not only improves performance but also it now absorbs the correct amount of water blocks. |
turt2live
added
PR: Needs Testing
PR: Ready To Pull
and removed
PR: Needs Testing
labels
|
Merged in 6e86a71. |
* Add the /playsound command * Add a factory for the SoundCategory enum * Simplify the unit tests for commands: setidletimeout, setworldspawnpoint, spawnpoint and toggleDownfall
This PR adds a general-purpose taxicab block iterator and employs it to add the block behaviour of sponges in 1.8.