Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show all problems when creating release notes, rather than just showing first problem #113

Closed
ghuntley opened this issue May 1, 2018 · 1 comment · Fixed by #369
Closed

Show all problems when creating release notes, rather than just showing first problem #113

ghuntley opened this issue May 1, 2018 · 1 comment · Fixed by #369
Assignees
@gep13
Labels
Improvement
Milestone
0.12.0

Comments

@ghuntley
Copy link

ghuntley commented May 1, 2018 •
edited
Loading

image

me right now

  1. run build - fail
  2. copy link
  3. edit github issue
  4. run build.
    [6 mins later]
  5. copy link ......

it's been a while since last release. :(

Will you take a PR that returns a collection of user actions instead of a single value?
@gep13 gep13 mentioned this issue Dec 10, 2019
Open
@gep13 gep13 added this to the 0.11.0 milestone Jan 6, 2020
@gep13 gep13 modified the milestones: 0.11.0, 0.12.0 Mar 16, 2020
@gep13 gep13 self-assigned this Apr 5, 2021
gep13 referenced this issue in gep13/GitReleaseManager Apr 12, 2021
@gep13
(#113) Collect all invalid issues together
3c4f8d7 
When there are issues that contain invalid issues, rather than throw
a single exception for the first problem, throw an exception that
contains information about all the problematic issues.  This saves the
end user from having to run GRM multiple times, fixing one issue at
a time.
gep13 referenced this issue in gep13/GitReleaseManager Apr 12, 2021
@gep13
(#113) Update unit tests for new functionality
d815190 
We are now throwing a specific exception, rather than an
InvalidOperationException.  Also, added new tests to assert the
correct number of errors returned in the new exception.
@gep13 gep13 mentioned this issue Apr 12, 2021
Merged
6 tasks
gep13 added a commit that referenced this issue Apr 19, 2021
@gep13
Merge pull request #369 from gep13/feature/GH113
ded0ef6 
(#113) Return all issues that have errors
@gep13 gep13 changed the title Idea: don't throw immediately if I've stuffed something up. dump a collection of stuffups Show all problems when creating release notes, rather than just showing first problem Apr 19, 2021
gep13 added a commit that referenced this issue May 31, 2021
@gep13
Merge branch 'release/0.12.0'
7a29d7e 
* release/0.12.0: (181 commits)
  (build) Fix unit tests
  Bump ApprovalTests from 5.4.7 to 5.5.0 in /src
  (#379) Validate old config file do not exist
  (#377) Add UploadUrl property to release model
  (#373) Ensure that release is located correctly
  (#374) Remove case sensitive search
  (#371) Add missing AutoMapper maps
  (#372) Always register TemplateRepository
  (build) Remove error action preference from build script
  Bump YamlDotNet from 11.0.1 to 11.1.1 in /src
  (#112) Updated docs with new command option
  (#112) Add new method for creating empty release
  (#113) Update unit tests for new functionality
  (#113) Collect all invalid issues together
  (#99) Fix unit tests
  (#99) Add SkipPrereleases option
  (#285) Fix editorconfig violations
  (maint) Run dotnet format
  (#143) Only build on Windows for time being
  (#143) Try running just Mac and Windows
  ...
gittools-bot pushed a commit that referenced this issue May 31, 2021
@gep13
Continuous Integration Publish: 7a29d7e
bb0bb10 
Merge branch 'release/0.12.0'

* release/0.12.0: (181 commits)
  (build) Fix unit tests
  Bump ApprovalTests from 5.4.7 to 5.5.0 in /src
  (#379) Validate old config file do not exist
  (#377) Add UploadUrl property to release model
  (#373) Ensure that release is located correctly
  (#374) Remove case sensitive search
  (#371) Add missing AutoMapper maps
  (#372) Always register TemplateRepository
  (build) Remove error action preference from build script
  Bump YamlDotNet from 11.0.1 to 11.1.1 in /src
  (#112) Updated docs with new command option
  (#112) Add new method for creating empty release
  (#113) Update unit tests for new functionality
  (#113) Collect all invalid issues together
  (#99) Fix unit tests
  (#99) Add SkipPrereleases option
  (#285) Fix editorconfig violations
  (maint) Run dotnet format
  (#143) Only build on Windows for time being
  (#143) Try running just Mac and Windows
  ...
@gittools-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.12.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

gittools-bot pushed a commit that referenced this issue May 31, 2021
@gep13
Continuous Integration Publish: 7a29d7e
007cc69 
Merge branch 'release/0.12.0'

* release/0.12.0: (181 commits)
  (build) Fix unit tests
  Bump ApprovalTests from 5.4.7 to 5.5.0 in /src
  (#379) Validate old config file do not exist
  (#377) Add UploadUrl property to release model
  (#373) Ensure that release is located correctly
  (#374) Remove case sensitive search
  (#371) Add missing AutoMapper maps
  (#372) Always register TemplateRepository
  (build) Remove error action preference from build script
  Bump YamlDotNet from 11.0.1 to 11.1.1 in /src
  (#112) Updated docs with new command option
  (#112) Add new method for creating empty release
  (#113) Update unit tests for new functionality
  (#113) Collect all invalid issues together
  (#99) Fix unit tests
  (#99) Add SkipPrereleases option
  (#285) Fix editorconfig violations
  (maint) Run dotnet format
  (#143) Only build on Windows for time being
  (#143) Try running just Mac and Windows
  ...
@gep13 gep13 mentioned this issue Jul 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Improvement
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

(#113) Return all issues that have errors gep13/GitReleaseManager
3 participants
@ghuntley @gep13 @gittools-bot