Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unpublished items in form #4319

Draft
wants to merge 2 commits into
base: 2.x
Choose a base branch
from
Draft

Allow unpublished items in form #4319

wants to merge 2 commits into from

Conversation

dafeder
Copy link
Member

@dafeder dafeder commented Oct 17, 2024

Describe your changes

Currently, if a keyword or other child item is unpublished, it will be invisible to the json_form_widget's autocomplete. This means if you create a dataset that is unpublished, then edit it again, the keywords will be missing from the form, and when you save will be removed.

QA Steps

  • Set default workflow state to "draft".
  • Create a dataset, add new keywords that were not previously in the autocomplete
  • Edit the dataset again, confirm that the keywords are still populated in the form.

Notes

This becomes unnecessary after the second save, when all child items are published. That workflow doesn't make a lot of sense though, and there is a todo to change that as well.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

@dafeder dafeder marked this pull request as ready for review December 12, 2024 21:26
@dafeder dafeder force-pushed the form-unpublished-list branch from a8a7559 to eaba040 Compare December 12, 2024 22:02
@dafeder dafeder self-assigned this Dec 12, 2024
@dafeder dafeder marked this pull request as draft December 12, 2024 22:03
@dafeder
Copy link
Member Author

dafeder commented Dec 12, 2024

Needs test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant