Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index UI unit tests #4262

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Index UI unit tests #4262

merged 5 commits into from
Aug 19, 2024

Conversation

dmundra
Copy link
Contributor

@dmundra dmundra commented Aug 13, 2024 •
edited
Loading

re: 17377

Describe your changes

Tests for #4185

QA Steps

  • Tests are passing in the pipeline and locally with the following command:
ddev dkan-phpunit \                                                                                                                 
                    --coverage-clover /var/www/html/docroot/modules/contrib/dkan/clover.xml \
                    --coverage-html /var/www/html/docroot/modules/contrib/dkan/coverage-html \
                    --log-junit /var/www/html/docroot/modules/contrib/dkan/junit/junit.xml --filter DataDictionaryWidgetBuildIndexesTest
  • Code coverage for /var/www/html/dkan/modules -> data_dictionary_widget -> src -> Indexes is > 50%

@dmundra dmundra marked this pull request as ready for review August 15, 2024 16:20
@dmundra dmundra self-assigned this Aug 15, 2024
@dmundra dmundra changed the title WIP: Index UI tests Index UI unit tests Aug 16, 2024
@rovcase rovcase self-requested a review August 19, 2024 19:19
rovcase
rovcase approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@rovcase rovcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, TY!

@rovcase rovcase merged commit a58f467 into Data-Dictionary-Index-Working Aug 19, 2024
8 checks passed
@rovcase rovcase deleted the 17377-index-tests branch August 19, 2024 20:35
dmundra added a commit that referenced this pull request Sep 6, 2024
@dmundra
Index UI unit tests (#4262)
26fa531
beeyayjay pushed a commit that referenced this pull request Jan 6, 2025
@dmundra
Index UI unit tests (#4262)
bfe705e
beeyayjay pushed a commit that referenced this pull request Jan 6, 2025
@dmundra
Index UI unit tests (#4262)
2250243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rovcase rovcase rovcase approved these changes

Assignees

@dmundra dmundra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmundra @rovcase