Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dependency on getdkan/contracts (part 1) #4177

Merged
merged 29 commits into from
Dec 19, 2024
Merged

Reduce dependency on getdkan/contracts (part 1) #4177

merged 29 commits into from
Dec 19, 2024

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented May 4, 2024

Partially fixes #3821

Old interface New interface
\Contracts\CountableInterface \Countable
\Contracts\HydratableInterface \Procrastinator\HydratableInterface
\Contracts\ParserInterface \CsvParser\Parser\ParserInterface

\Contracts\RetrieverInterface and \Contracts\StorerInterface remain in getdkan/contracts because there is no clear place to move them. They're needed within multiple libraries. Refactor this in a followup.

We also need to keep getdkan/contracts as a dependency in many places because some libraries use Contracts\Mock\Storage\Memory for tests. Refactor this in a followup.

Our changes to Drupal\common\Storage\Query... See the @todo which asks if we should just make a QueryInterface.

Merge Steps

In order to make all these changes, we have to modify the following libraries, maybe in this order.

Each PR is a branch named no-contracts, some of which have interdependencies on each other. These PRs will need to be updated to require the release of each of these dependencies.

@paul-m paul-m changed the title Remove dependency on getdkan/contracts Reduce dependency on getdkan/contracts (part 1) May 13, 2024
@paul-m paul-m mentioned this pull request Sep 30, 2024
3 tasks
@paul-m paul-m added the dependencies Pull requests that update a dependency file label Sep 30, 2024
@dafeder dafeder self-assigned this Nov 20, 2024
@paul-m paul-m marked this pull request as ready for review December 9, 2024 19:10
@dafeder dafeder assigned paul-m and unassigned dafeder Dec 16, 2024
@dafeder
Copy link
Member

dafeder commented Dec 16, 2024

Dependencies merged and released

@dafeder dafeder merged commit b5dbac6 into 2.x Dec 19, 2024
11 checks passed
@dafeder dafeder deleted the no-contracts branch December 19, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependencies on getdkan/contracts
2 participants