correct both addressA and addressB for OOB probes when channel swapping #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcmaxson
added a commit
that referenced
this pull request
Jul 6, 2022
* Feature/v1.6.3 (#108) * GEO download much improved and should handle more datastets; passes tests * version fix * changed test dataset to 450k, b/c 27k not fully supported * correct both addressA and addressB for OOB probes when channel swapping (#111) * correct both addressA and addressB for OOB probes * cleaner solution to getting address A and B from lookup * tests passing; changed ref values slightly * Addition of negative control based pvalue calculation (#109) * Update pOOBAH pval calculation * added feature to output negative control based pvalue - pNegECDF_pval Co-authored-by: Chavez, Mauro <[email protected]> Co-authored-by: Mauro Chavez <[email protected]> Co-authored-by: Chavez, Mauro <[email protected]>
marcmaxson
added a commit
that referenced
this pull request
Jul 8, 2022
* working parquet * incorp Mauro's updates (pNegECDF and infer switch) into v1.7.0 (#112) * Feature/v1.6.3 (#108) * GEO download much improved and should handle more datastets; passes tests * version fix * changed test dataset to 450k, b/c 27k not fully supported * correct both addressA and addressB for OOB probes when channel swapping (#111) * correct both addressA and addressB for OOB probes * cleaner solution to getting address A and B from lookup * tests passing; changed ref values slightly * Addition of negative control based pvalue calculation (#109) * Update pOOBAH pval calculation * added feature to output negative control based pvalue - pNegECDF_pval Co-authored-by: Chavez, Mauro <[email protected]> Co-authored-by: Mauro Chavez <[email protected]> Co-authored-by: Chavez, Mauro <[email protected]> Co-authored-by: Mauro Chavez <[email protected]> Co-authored-by: Chavez, Mauro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current implementation identifies out of band probes but only swaps the color channels for one of the two probe's addresses