-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for partial indices #7257
Conversation
Thank you for implementing this. Next step partial |
FOR (REQUEST_HANDLE tdgbl->handles_put_index_req_handle1) | ||
X IN RDB$INDICES WITH | ||
X.RDB$RELATION_NAME EQ relation->rel_name | ||
if (tdgbl->runtimeODS >= DB_VERSION_DDL13_1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff comparation is not easy here.
Can't we use unique code where non-existent fields are read as NULL?
Or are you preventing problem of new gbak being connected to very old engine that treat non-existent fields as error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is to please old engine versions.
src/burp/restore.epp
Outdated
@@ -6616,6 +6649,40 @@ bool get_index(BurpGlobals* tdgbl, const burp_rel* relation) | |||
general_on_error (); | |||
END_ERROR; | |||
|
|||
if (hasConditionSrc || hasConditionBlr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. Write to non-existent fields is possible since many versions ago.
I suppose that if v4 opens an ODS 13.1 database with partial index, it may not work properly, trying to find entries in index without considering its condition, correct? Do we consider these cases as valid for minor ODS upgrade? |
v4 cannot attach an ODS 13.1 database. |
✅ Build firebird 1.0.4757 completed (commit 91eb884b4f by @hvlad) |
Following script causes FB crash (checked on 5.0.0.938; problem in line marked as "[ ! ]"):
|
… example in #7257). Better resource cleanup on error. Remove redundant ODS checks.
@pavel-zotov Should be fixed now. |
@@@ QA issue @@@ |
As requested in #3750. Also supported by MS SQL, PostgreSQL, SQLite, MongoDB. Brief description can be found in Wikipedia.