Skip to content

Commit

Permalink
Merge pull request #7737 from red-soft-ru/5_0_blob_precedence_fixes
Browse files Browse the repository at this point in the history
Fix cases where the precedence relationship between a record page and a blob page is not set
  • Loading branch information
ilya071294 authored Sep 6, 2023
2 parents 8e61e11 + ed3287c commit 4560aad
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 11 deletions.
1 change: 1 addition & 0 deletions src/jrd/blb.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,7 @@ void BLB_garbage_collect(thread_db* tdbb,
**************************************/
SET_TDBB(tdbb);

fb_assert(prior_page > 0);
RecordBitmap bmGoing;
ULONG cntGoing = 0;

Expand Down
25 changes: 14 additions & 11 deletions src/jrd/vio.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2485,25 +2485,26 @@ static void delete_version_chain(thread_db* tdbb, record_param* rpb, bool delete

ULONG prior_page = 0;

if (!delete_head)
// Note that the page number of the oldest version in the chain should
// be stored in rpb->rpb_page before exiting this function because
// VIO_intermediate_gc will use it as a prior page number.
while (rpb->rpb_b_page != 0 || delete_head)
{
prior_page = rpb->rpb_page;
rpb->rpb_page = rpb->rpb_b_page;
rpb->rpb_line = rpb->rpb_b_line;
}
if (!delete_head)
{
prior_page = rpb->rpb_page;
rpb->rpb_page = rpb->rpb_b_page;
rpb->rpb_line = rpb->rpb_b_line;
}
else
delete_head = false;

while (rpb->rpb_page != 0)
{
if (!DPM_fetch(tdbb, rpb, LCK_write))
BUGCHECK(291); // msg 291 cannot find record back version

record_param temp_rpb = *rpb;
DPM_delete(tdbb, &temp_rpb, prior_page);
delete_tail(tdbb, &temp_rpb, temp_rpb.rpb_page);

prior_page = rpb->rpb_page;
rpb->rpb_page = rpb->rpb_b_page;
rpb->rpb_line = rpb->rpb_b_line;
}
}

Expand Down Expand Up @@ -3678,6 +3679,8 @@ bool VIO_modify(thread_db* tdbb, record_param* org_rpb, record_param* new_rpb, j
org_rpb->rpb_flags &= ~(rpb_delta | rpb_uk_modified);
org_rpb->rpb_flags |= new_rpb->rpb_flags & (rpb_delta | rpb_uk_modified);

stack.merge(new_rpb->rpb_record->getPrecedence());

replace_record(tdbb, org_rpb, &stack, transaction);

if (!(transaction->tra_flags & TRA_system) &&
Expand Down

0 comments on commit 4560aad

Please sign in to comment.