Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

feat: Update the logo with the EddieHub Mascot #318

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

ninadvyas
Copy link
Contributor

@ninadvyas ninadvyas commented Dec 8, 2023

Closes #265 Update the logo with the EddieHub Mascot :

Changes proposed

  • Change the previous logo in the header with the eddihub mascot.
  • Change the file with the new logo accordingly & delete previous file.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots of #265

Before:
Screenshot 2023-12-08 at 12 38 35 PM

After:
Screenshot 2023-12-08 at 12 39 16 PM

Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2023 10:15am

@@ -24,8 +24,8 @@ export function Footer() {
>
{[
[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look irrelevant, please make them in a different PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xkrishguptaa what exactly I need to do. As I am understanding I need to make another PR for the footer changes am right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ninadvyas you are fixing two issues right? Please keep this PR only for the EddieHub Mascot fix and do the links of partner's fix in a different PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fixing two issues. Can you teach me how to make different PR because I have committed changes in my main branch and according to me I have to make another branch for another PR. Is that correct? @xkrishguptaa

@ninadvyas
Copy link
Contributor Author

ninadvyas commented Dec 17, 2023

Hello @xkrishguptaa I have made changes this PR only changes the EddieHub Mascot fix. Kindly waiting for the feedback.

Copy link
Member

@adityaraute adityaraute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkrishguptaa kkrishguptaa linked an issue Dec 28, 2023 that may be closed by this pull request
@kkrishguptaa kkrishguptaa merged commit 7413041 into EddieHubCommunity:main Dec 28, 2023
1 check passed
@kkrishguptaa kkrishguptaa changed the title #265 - [FEATURE] Update the logo with the EddieHub Mascot feat: Update the logo with the EddieHub Mascot Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Update the logo with the EddieHub Mascot
3 participants