-
-
Notifications
You must be signed in to change notification settings - Fork 119
feat: Update the logo with the EddieHub Mascot #318
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/components/Footer.jsx
Outdated
@@ -24,8 +24,8 @@ export function Footer() { | |||
> | |||
{[ | |||
[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look irrelevant, please make them in a different PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xkrishguptaa what exactly I need to do. As I am understanding I need to make another PR for the footer changes am right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ninadvyas you are fixing two issues right? Please keep this PR only for the EddieHub Mascot fix and do the links of partner's fix in a different PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fixing two issues. Can you teach me how to make different PR because I have committed changes in my main branch and according to me I have to make another branch for another PR. Is that correct? @xkrishguptaa
Hello @xkrishguptaa I have made changes this PR only changes the EddieHub Mascot fix. Kindly waiting for the feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #265
Update the logo with the EddieHub Mascot :Changes proposed
Check List (Check all the applicable boxes)
Screenshots of #265
Before:
After: