lmu2png: fix bad offset on right-edge of terrain autotiles #94
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for lmu2png. The right edge of terrain autotiles are drawn wrong on one-tile-wide vertical strips.
Before/after this patch:
This right half of the tile is drawn by this line
Tools/lmu2png/src/chipset.cpp
Line 290 in 0772ab7
Note that this draws the left half of the chip into the right half of the destination.
I don't understand any of the
Combination
stuff, but I don't think that should ever happen, so I'm guessing this is a typo and it should be drawing the right half of the chip instead ie. the offset needs to move right 8 pixels.