-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Maniacs Command 3011: ChangeBattleCommandEx #3290
Implemented Maniacs Command 3011: ChangeBattleCommandEx #3290
Conversation
…selected (just like Maniacs). Also fixed a case where the options for auto battle were not shown despite having other options available to use by the player: Win/Lose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. The logic of the code itself is fine. I just have style/idiom nits. You could not know them as is your first contribution.
…c/readability improvements based on Ghabry's feedback.
Jenkins: test this please @MakoInfused I'll send you an invite for the "Player Team". When you accept it then the PR builders will run automatically... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one build failure is just a timeout so LGTM 👍
Jenkins: retest this please |
Using the maniacs patch ChangeBaltteCommandEx with something like this:
Will now give you the expected behavior in EasyRPG:
And for the actors themselves (in my example the row command is turned off):
Developers can mix and match these features and all commands are supported. Including the "Win" and "Lose" commands.