Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Maniacs Command 3011: ChangeBattleCommandEx #3290

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

MakoInfused
Copy link
Contributor

Using the maniacs patch ChangeBaltteCommandEx with something like this:
image

Will now give you the expected behavior in EasyRPG:
image

And for the actors themselves (in my example the row command is turned off):
image

Developers can mix and match these features and all commands are supported. Including the "Win" and "Lose" commands.

…selected (just like Maniacs).

Also fixed a case where the options for auto battle were not shown despite having other options available to use by the player: Win/Lose
Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. The logic of the code itself is fine. I just have style/idiom nits. You could not know them as is your first contribution.

src/game_interpreter_battle.cpp Outdated Show resolved Hide resolved
src/game_interpreter_battle.cpp Outdated Show resolved Hide resolved
src/game_interpreter_battle.cpp Outdated Show resolved Hide resolved
src/scene_battle_rpg2k3.cpp Outdated Show resolved Hide resolved
…c/readability improvements based on Ghabry's feedback.
@MakoInfused MakoInfused requested a review from Ghabry November 7, 2024 12:35
@Ghabry Ghabry added this to the 0.8.1 milestone Nov 7, 2024
@Ghabry
Copy link
Member

Ghabry commented Nov 7, 2024

Jenkins: test this please

@MakoInfused I'll send you an invite for the "Player Team". When you accept it then the PR builders will run automatically...

Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one build failure is just a timeout so LGTM 👍

@MakoInfused
Copy link
Contributor Author

Jenkins: retest this please

@Ghabry Ghabry merged commit edc1377 into EasyRPG:master Nov 8, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants