Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maniac Pictures: Support Origin, Fixed Angle and Frames for duration #2741

Merged
merged 3 commits into from
Mar 25, 2022
Merged

Maniac Pictures: Support Origin, Fixed Angle and Frames for duration #2741

merged 3 commits into from
Mar 25, 2022

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented Feb 28, 2022 •
edited
Loading

Okay kinda clickbait. Origin is not supported yet because I cannot figure out some rounding errors.
But it will come this week ;)

Wanted an issue number already for the metabug (#1818)

  • Fixed Angle standalone
  • Switching from Fixed Angle to other effects (this looks bad because maniac uses 360°, rest 256°, not my fault)
  • How many frames Move picture lasts
  • Origin

@Ghabry Ghabry added this to the 0.7.1 milestone Feb 28, 2022
@Ghabry Ghabry mentioned this pull request Feb 28, 2022
Open
27 tasks
@Ghabry Ghabry force-pushed the maniac/picrotation branch from 5ce904a to deba09e Compare March 17, 2022 00:38
@Ghabry Ghabry added the Has PR Dependencies This PR depends on another PR label Mar 17, 2022
@Ghabry Ghabry marked this pull request as ready for review March 17, 2022 00:39
@Ghabry
Copy link
Member Author

Ghabry commented Mar 17, 2022

Origin works now for Show and Move Picture.
Depends now on #2735 due to conflicts.

@fdelapena fdelapena added Awaiting Rebase Pull requests with conflicting files due to former merge and removed Has PR Dependencies This PR depends on another PR labels Mar 24, 2022
@Ghabry Ghabry force-pushed the maniac/picrotation branch from deba09e to e33e6f8 Compare March 24, 2022 19:44
@Ghabry Ghabry removed the Awaiting Rebase Pull requests with conflicting files due to former merge label Mar 24, 2022
@fdelapena fdelapena merged commit efcfdf1 into EasyRPG:master Mar 25, 2022
@Ghabry Ghabry deleted the maniac/picrotation branch May 29, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Pictures RPG_RT Patches
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Ghabry @fdelapena