-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking Changes] New v6 API for Swift and ObjC #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enable chainning and make variables public - Should deprecate old API at 7.0.0 version
ApolloZhu
changed the title
[Breaking Changes] New v6 API
[Breaking Changes] New v6 API for Swift and ObjC
Nov 25, 2020
Codecov Report
@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 58.80% 61.50% +2.70%
==========================================
Files 14 15 +1
Lines 869 982 +113
==========================================
+ Hits 511 604 +93
- Misses 358 378 +20
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This was referenced Dec 9, 2020
Closed
Examples of the new API: |
EyreFree
approved these changes
Dec 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EFQRCodeMode.none
toEFQRCodeMode?.none
, i.e.nil
EFQRCodeGenerator.with<T>(_: ReferenceWritableKeyPath<Self, T>, _: T) -> Self
to set property directly and chain invocationsEFQRCode+Migration-v6.swift
) aredeprecated
, and should be marked asobsoleted
/unavailable
with v7 release, and the file completely deleted with v8 release.EFQRCodeGenerator
,EFQRCodeRecognizer
are now equally available in Swift/ObjC, andEFQRCode
will be Swift onlyEFUIntPixel
appears to be not an active part of the existing public API, so it will no longer bepathToSave
from GIF generation API