Add Color Code Display for Single Color Filaments #526
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Donkie
reviewed
Nov 18, 2024
client/src/components/spoolIcon.css
Outdated
| @@ -3,7 +3,6 @@ | |||
| width: 1.5em; | |||
| height: 2.5em; | |||
| gap: 2px; | |||
| margin: 0 0.5em; | |||
There was a problem hiding this comment.
This doesn't look so good in the spool list, the text is butted up against the color block. Why did you remove this?
There was a problem hiding this comment.
Just an UI/UX improvement.
During development, I saw, that the color is not aligned to the same spot as other records. I thought this was not intended.
If this was your intention, I will revert the change 😊
There was a problem hiding this comment.
Oh okay, I see the issue! Will fix that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR enhances the user experience for tools like HueForge by displaying color codes directly beneath the color icon for single-color filaments. This addition makes it easier for users to access and utilize color information without additional steps.
Thanks for considering this improvement!