Change approch to filter files extract by "gallery extraction" feature #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rst, then apply image filtering during display. If identical images are found in different formats (e.g., ico and png), only the png version is shown.
DineshSolanki
deleted the
211-gallery-extraction-issue-when-both-png-and-ico-are-present
branch
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of filtering the compressed stream, extract all files first, then apply image filtering during display. If identical images are found in different formats (e.g., ico and png), only the png version is shown.
The progress bar will show count for all files as all are being downloaded and extracted, however in case of duplicate, png file will be prioritized so user may see less files then displayed on progress bar