fix: Improve error handling and remove unnecessary async

Enhanced error handling in `ProcessUtils.cs` by adding detailed error messages and throwing `InvalidOperationException`. Removed the unnecessary ` async ` keyword from `LoadGameData` in `PosterPickerViewModel.cs` as the method does not contain any async operations.
DineshSolanki · Jul 27, 2024 · 95d2a19 · 95d2a19
1 parent 49db1e2
commit 95d2a19
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/FoliCon/Modules/utils/ProcessUtils.cs b/FoliCon/Modules/utils/ProcessUtils.cs
@@ -24,8 +24,10 @@ public static void StartProcess(string path)
         }
         catch (Exception e)
         {
-            Logger.Error(e, "Failed to start process: {ExceptionMessage}", e.Message);
-            throw;
+            var detailedErrorMessage = $"Failed to start process at path: {path}. Exception: {e.Message}";
+
+            Logger.Error(e, detailedErrorMessage);
+            throw new InvalidOperationException(detailedErrorMessage, e);
         }
     }
 

diff --git a/FoliCon/ViewModels/PosterPickerViewModel.cs b/FoliCon/ViewModels/PosterPickerViewModel.cs
@@ -100,7 +100,7 @@ public async Task LoadData()
 
         if (resultType == MediaTypes.Game)
         {
-            await LoadGameData(response);
+            LoadGameData(response);
         }
         else
         {
@@ -177,7 +177,7 @@ private async Task<ImagesWithId> GetTitleAndImages(string resultType, dynamic re
         };
     }
 
-    private async Task LoadGameData(dynamic response)
+    private void LoadGameData(dynamic response)
     {
         Logger.Debug("Media Type is Game, loading images from IGDB");
         Artwork[] images = response.Artworks.Values;