fix: Remove async/await from sync methods and add static modifier

Refactored methods in PosterPickerViewModel to remove unnecessary async/await usage for synchronous operations. Made ProcessSubfolders method in MainWindowViewModel static to align it with its usage context. Added an async keyword to SearchAgainMethod to correctly await StartSearch execution in SearchResultViewModel.

FoliCon/ViewModels/MainWindowViewModel.cs

@@ -534,7 +534,7 @@ private void AddToFinalList(string itemTitle)
         }
     }
 
-    private void ProcessSubfolders(string folderPath, Queue<string> folderQueue)
+    private static void ProcessSubfolders(string folderPath, Queue<string> folderQueue)
     {
         Logger.Trace("Subfolder Processing Enabled, Processing Subfolders.");
         var folders = FileUtils.GetAllSubFolders(folderPath, Services.Settings.Patterns);

FoliCon/ViewModels/PosterPickerViewModel.cs

@@ -141,7 +141,7 @@ private async Task LoadMediaData(string resultType, dynamic response)
         if (images != null)
         {
             var imageDataWrappers = images.Posters.Select(imageData => new ImageDataWrapper(images.Id, imageData, TmdbObject.GetClient()));
-            await LoadImages(imageDataWrappers);
+            LoadImages(imageDataWrappers);
         }
     }
 
@@ -196,13 +196,13 @@ private async Task LoadGameData(dynamic response)
         Logger.Debug("Media Type is Game, loading images from IGDB");
         Artwork[] images = response.Artworks.Values;
         var artworkWrappers = images.Select(artwork => new ArtworkWrapper(artwork));
-        await LoadImages(artworkWrappers);
+        LoadImages(artworkWrappers);
     }
 
     #endregion
 
 
-    private async Task LoadImages(IEnumerable<IImage> images)
+    private void LoadImages(IEnumerable<IImage> images)
     {
         ResetState();
         IsBusy = true;

FoliCon/ViewModels/SearchResultViewModel.cs

@@ -268,11 +268,11 @@ private void LoadData(string searchTitle)
         PerformSelectionChanged();
     }
 
-    private void SearchAgainMethod()
+    private async void SearchAgainMethod()
     {
         if (!string.IsNullOrWhiteSpace(SearchAgainTitle))
         {
-            StartSearch(false);
+            await StartSearch(false);
         }
     }