Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ValidatorJS] Add isISO31661Alpha3 #36978

Merged
merged 3 commits into from
Jul 23, 2019
Merged

[ValidatorJS] Add isISO31661Alpha3 #36978

merged 3 commits into from
Jul 23, 2019

Conversation

henrikra
Copy link
Contributor

I noticed that ValidatorJS has isISO31661Alpha3 but the types don't have it.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/validatorjs/validator.js#validators
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Jul 18, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 18, 2019

@henrikra Thank you for submitting this PR!

🔔 @tgfjt @chrootsu @IOAyman @louy @kacepe @deptno @builtinnya @qqilihq @keatz55 - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@henrikra
Copy link
Contributor Author

@osdiab @kacepe @amcasey Can you guys check this out? :)

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #36978 diff
Batch compilation
Memory usage (MiB) 35.9 36.0 +0.2%
Type count 2364 2365 0.0%
Assignability cache size 119 119 0.0%
Subtype cache size 0 0
Identity cache size 0 0
Language service
Samples taken 1388 1397 +0.6%
Identifiers in tests 1388 1397 +0.6%
getCompletionsAtPosition
    Mean duration (ms) 124.0 126.2 +1.8%
    Median duration (ms) 122.5 124.3 +1.5%
    Mean CV 17.5% 17.7% +1.4%
    Worst duration (ms) 305.6 315.0 +3.1%
    Worst identifier extend extend
getQuickInfoAtPosition
    Mean duration (ms) 116.7 118.3 +1.4%
    Median duration (ms) 117.6 118.0 +0.4%
    Mean CV 17.0% 17.2% +1.1%
    Worst duration (ms) 171.9 185.6 +7.9%
    Worst identifier extend _normalizeEmail

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@osdiab
Copy link
Contributor

osdiab commented Jul 18, 2019

Looks about right to me!

@henrikra
Copy link
Contributor Author

@osdiab so what happens next?

@osdiab
Copy link
Contributor

osdiab commented Jul 19, 2019

@henrikra I'm not a maintainer, so we just wait for one of them to show up, give it the thumbs up and then merge in. Shouldn't be too long! But if none of them show up in a reasonable timeframe typescript-bot will loop in DefinitelyTyped people to review it instead.

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Jul 23, 2019
@typescript-bot
Copy link
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@weswigham weswigham merged commit e1f00aa into DefinitelyTyped:master Jul 23, 2019
iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
* Add isISO31661Alpha3

* Move to new structure
breeze9527 pushed a commit to breeze9527/DefinitelyTyped that referenced this pull request Jan 27, 2020
* Add isISO31661Alpha3

* Move to new structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts). Unmerged The author did not merge the PR when it was ready.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants