-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ValidatorJS] Add isISO31661Alpha3 #36978
[ValidatorJS] Add isISO31661Alpha3 #36978
Conversation
@henrikra Thank you for submitting this PR! 🔔 @tgfjt @chrootsu @IOAyman @louy @kacepe @deptno @builtinnya @qqilihq @keatz55 - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place. If you have any questions or comments about me, you can ping |
Looks about right to me! |
@osdiab so what happens next? |
@henrikra I'm not a maintainer, so we just wait for one of them to show up, give it the thumbs up and then merge in. Shouldn't be too long! But if none of them show up in a reasonable timeframe typescript-bot will loop in |
After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience! |
* Add isISO31661Alpha3 * Move to new structure
* Add isISO31661Alpha3 * Move to new structure
I noticed that ValidatorJS has isISO31661Alpha3 but the types don't have it.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
.