BUG: Need to include extension in temporary EVL to import into Echoview #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even when fname is a full path.
Needed so Echoview can import correctly, as it uses the extension.
No need to as it should just be the same file. Not using a temp file should make it easier to debug since we will usually be importing the file which persists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include extension in temporary EVL file so it can be imported into Echoview.
Also, refactor such that temporary EVL files are only generated if clipping is needed (otherwise use the original EVL file).
And adjust the error messages to use the temporary file's path if used.