Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ValidationContext support IServiceProvider. #48

Merged
merged 4 commits into from
Jun 22, 2023
Merged

Make ValidationContext support IServiceProvider. #48

merged 4 commits into from
Jun 22, 2023

Conversation

maliming
Copy link
Contributor

We can get services from ValidationContext in this way. : )

DamianEdwards
DamianEdwards requested changes Jun 21, 2023
View reviewed changes
Copy link
Owner

@DamianEdwards DamianEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just a small change requested around the argument checking of the public methods. Also you can bump the version to 0.8.0 in src/Directory.Build.props

src/MiniValidation/MiniValidator.cs Outdated Show resolved Hide resolved
src/MiniValidation/MiniValidator.cs Outdated Show resolved Hide resolved
src/MiniValidation/MiniValidator.cs Outdated Show resolved Hide resolved
@maliming maliming marked this pull request as ready for review June 22, 2023 08:10
@maliming maliming requested a review from DamianEdwards June 22, 2023 08:10
@maliming maliming mentioned this pull request Jun 22, 2023
Open
@DamianEdwards DamianEdwards merged commit 81b5c92 into DamianEdwards:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamianEdwards DamianEdwards DamianEdwards approved these changes

@thoemmi thoemmi thoemmi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maliming @thoemmi @DamianEdwards