Fix tigl wing get segment upper surface area trimmed #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joergbrech Thanks for finding and fixing this bug! I took your fix and created this PR with it. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #960 +/- ##
==========================================
- Coverage 68.76% 68.75% -0.01%
==========================================
Files 299 299
Lines 26483 26481 -2
==========================================
- Hits 18210 18208 -2
Misses 8273 8273
|
joergbrech
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #961
Bug Description
The API function tiglWingGetSegmentUpperSurfaceAreaTrimmed(...) terminated with return code 1, when passing the valid arguments (tiglHandle, 1, 1, 0, 0, 0, 1, 0.05, 1, 0.05, 0, double*ReturnValue).
Bug Analysis
This bug arises due to the fact that the implementation of the mentioned function contained a cast from TopoDS_Compound to a TopoDS_Face. As the used test data configuration has the property, that both its upper and lower wing consists of more than one face, respectively, arising through the use of additional guide curves, both the upper and lower wing are given by compounds containing more than one element, respectively. Trying to cast each of these compounds to a face yields an error.
The bug originates due to the fact that earlier, both upper and lower wings consisted of only one face, respectively. Hence, the mentioned conversion was not a problem.
Bug Fix
It has been fixed by avoiding these falsy conversions by minor refactoring of the code.
How Has This Been Tested?
Two unit tests have been added: One test for the correct return value of the above API function, and the second giving a roughly estimated check if the computed area leads to the right value.