Fix bug in wing cell creation #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #931 +/- ##
==========================================
+ Coverage 69.52% 69.56% +0.04%
==========================================
Files 298 298
Lines 24974 25014 +40
==========================================
+ Hits 17363 17401 +38
- Misses 7611 7613 +2
|
|
If you agree with the two suggestions, I will approve this PR from my side. Thanks for finding the bug! |
Co-authored-by: AntonReiswich <[email protected]>
Co-authored-by: AntonReiswich <[email protected]>
joergbrech
deleted the
930-wrong-wing-cell-generation-of-the-lower-shell
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #930.
The code for creating wing cells based on contour coordinates contained a small bug in mapping
uparameters of the wing faces to CPACS contour coordinates:The internal
uparameters go from lower trailing edge over the leading edge to upper trailing edge. The CPACS contour coordinates always go from leading edge to trailing edge. The differentiation between upper and lower side is clear from the CPACS hierarchy.This means that for the lower side, the contour coordinates and internal
ucoordinates have a reversed orientation, while for the upper side they do not. This was not properly taken into account before.How Has This Been Tested?
A new test case has been added specifically for this issue.
Screenshots, that help to understand the changes(if applicable):
See the issue description #930.
Checklist:
[ ] New classes have been added to the Python interface.[ ] API changes were documented properly in tigl.h.