style(tabbed-view): change tab view to use stepper #4587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syoopie
changed the title
syoopie
force-pushed
the
yoopie/fix-tab-overflow
branch
from
64fdce2 to
a3e2d0d
Compare
ekowidianto
reviewed
May 12, 2022
| </SvgIcon> | ||
| } | ||
| onClick={() => { | ||
| if (published || graderView) { |
There was a problem hiding this comment.
Oh that shouldnt be there it blocks students from changing questions
Refactored some code from the autograding pages to the manual grading pages Change the tabbed view to use MUI Stepper instead of Tabs
syoopie
force-pushed
the
yoopie/fix-tab-overflow
branch
from
a3e2d0d to
62ebaad
Compare
|
Style-wise LGTM, I'd prefer to not include Q infront of each question number to maintain consistency with autograded type of assessments. Can we make that change for consistency? |
|
I think the Q isnt there already. Just that the images in the description is not updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tab view was previous not scrollable on smaller screens / mobile, allowing for both scrollable and fullwidth is deferred to MUI v6
mui/material-ui#15324
Thus the solution is to change MUI tabs to steppers instead, so that it is more standardized with what is being used in the autograded pages as well.
fixes #4529
Examples:
No overflow
Overflow