Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capella signed voluntary exit was not published on Deneb #8205

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

zilm13
Copy link
Contributor

@zilm13 zilm13 commented Apr 15, 2024

PR Description

Not sure it's the case of #8158 report because it lacks of the information, but it's a valid case and we shouldn't fail on it. Fixed now.
Not sure about Changelog.

So, user could create and sign VoluntaryExit in Capella and send it later in any other fork and it's a valid SignedVoluntaryExit which we should publish.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucassaldanha lucassaldanha merged commit 49a6665 into Consensys:master Apr 15, 2024
16 checks passed
@zilm13 zilm13 deleted the fix-voluntary-exit branch April 16, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants