Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The maintenance page is not displayed for previously logged in users. #321

Closed
kushh23 opened this issue Sep 25, 2022 · 3 comments · Fixed by #322 or #329
Closed

The maintenance page is not displayed for previously logged in users. #321

kushh23 opened this issue Sep 25, 2022 · 3 comments · Fixed by #322 or #329
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@kushh23
Copy link

kushh23 commented Sep 25, 2022 •
edited
Loading

Description:

A user from wp.org reported that if a user apart from the admin role (a subscriber etc) is previously logged in to the dashboard then the wp-maintenance page will not be displayed for the user. Instead of the maintenance page, the user will see the homepage of the website. Although if he clicks any menu links or anything else he won't be able to access that, the homepage will be still visible. New visitors who are not logged in to the website will see the same page that you have selected for Maintenance mode.

By further investigating this issue, I could replicate the same behavior in my instance.

Note: The settings for frontend and backend access are set to default i.e only the administrator can have the access to frontend as well as the backend. Also, I have attached the screenshot of the plugin settings page below.

How to reproduce:

  1. Create a new demo user with any role. For example, subscriber.
  2. Open the website in a different browser or in a new incognito tab.
  3. Login with the credentials of this new account.
  4. Now Install the plugin and activate the Maintenance mode.
  5. Go to that tab where the user is logged in.
  6. Refresh the page or click any link.
  7. You will see that the Maintenance page that you have selected won't be displayed for the user.
  8. Now log out or open the link on a new browser and the maintenance page will be visible again.

Expected behavior:

The same Maintenance page should be visible to all users.

Current behavior:

The Home page of the website is visible to the Previously logged-in users during the maintenance mode.

Reference:

Plugin settings are set to default:

image

Screencast of issue : https://www.loom.com/share/336981d01b844630a3f4cb71dd38f3ad

The user reported here: https://wordpress.org/support/topic/maintenance-mode-not-showing-for-prev-logged-in-users/

If you want you can test this issue on this instance:

https://sleeptemper.s1-tastewp.com/
kushnamdev (admin)
J2SXFOO2CHI

The demo user credentials:
test (subscriber)
1234

Technical info

  • WordPress version: 6.0.2
  • Plugin version: 2.5.1
@kushh23 kushh23 added the bug This label could be used to identify issues that are caused by a defect in the product. label Sep 25, 2022
girishpanchal30 added a commit that referenced this issue Sep 26, 2022
@girishpanchal30
Fix maintenance mode issue for previously logged users #321
0850e6f
@girishpanchal30 girishpanchal30 mentioned this issue Sep 26, 2022
Merged
@girishpanchal30 girishpanchal30 linked a pull request Sep 26, 2022 that will close this issue
Fix maintenance mode issue for previously logged users #322
Merged
@girishpanchal30
Copy link
Contributor

Hey @kushh23

Mentioned issue is fixed. Please check with this PR #322

Thanks

@kushh23
Copy link
Author

kushh23 commented Sep 26, 2022

Hey @girishpanchal30,

I checked the plugin build and the issue is fixed now.

Thanks

@selul selul linked a pull request Sep 27, 2022 that will close this issue
Development #329
Merged
@selul selul mentioned this issue Sep 27, 2022
Merged
selul added a commit that referenced this issue Sep 27, 2022
@selul
release: fixes
2f07a64 
* Fix maintenance mode issue for previously logged users #321 
* Allow comments into exclude textarea so that you can comment on the IP addresses for location, props @joostdekeijzer 
* Fix PHP notice errors on specific scenarios #324 
* Fix Otter for saving subscriber entry
pirate-bot added a commit that referenced this issue Sep 27, 2022
@pirate-bot
chore(release): 2.5.2
620ab30 
##### [Version 2.5.2](v2.5.1...v2.5.2) (2022-09-27)

* Fix maintenance mode issue for previously logged users [#321](#321)
* Allow comments into exclude textarea so that you can comment on the IP addresses for location, props [@joostdekeijzer](https://github.com/joostdekeijzer)
* Fix PHP notice errors on specific scenarios [#324](#324)
* Fix Otter for saving subscriber entry
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.5.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
3 participants
@pirate-bot @girishpanchal30 @kushh23