Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and cleanup cmake files #5

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

ClausKlein
Copy link
Owner

@ClausKlein ClausKlein commented Nov 29, 2022

Add notes how to create and export the component targets

@@ -5,7 +5,7 @@ add_library(
Addition Addition.cxx ${NAMESPACE_HEADER_LOCATION}/${PROJECT_HEADER_LOCATION}/Addition.h
)

add_library(${PROJECT_NAMESPACE}::Addition ALIAS Addition)
add_library(${PROJECT_NAMESPACE}::Addition ALIAS Addition) # NOTE: needed! CK
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed

@@ -24,7 +24,7 @@ target_include_directories(
$<INSTALL_INTERFACE:${INCLUDE_INSTALL_DIR}>
)

# install the target and create export-set
# NOTE: Need to install the target and create export-set manually! CK
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed

@@ -6,7 +6,7 @@ add_library(
${NAMESPACE_HEADER_LOCATION}/${PROJECT_HEADER_LOCATION}/MathFunctions.h
)

add_library(MathFunctions::MathFunctions ALIAS MathFunctions)
add_library(${PROJECT_NAMESPACE}::MathFunctions ALIAS MathFunctions) # NOTE: needed! CK
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed

@@ -23,7 +23,7 @@ target_include_directories(
$<INSTALL_INTERFACE:${INCLUDE_INSTALL_DIR}>
)

# install the target and create export-set
# NOTE: Need to install the target and create export-set manually! CK
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed

@@ -5,7 +5,7 @@ add_library(
SquareRoot SquareRoot.cxx ${NAMESPACE_HEADER_LOCATION}/${PROJECT_HEADER_LOCATION}/SquareRoot.h
)

add_library(${PROJECT_NAMESPACE}::SquareRoot ALIAS SquareRoot)
add_library(${PROJECT_NAMESPACE}::SquareRoot ALIAS SquareRoot) # NOTE: needed! CK
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed

@@ -24,7 +24,7 @@ target_include_directories(
$<INSTALL_INTERFACE:${INCLUDE_INSTALL_DIR}>
)

# install the target and create export-set
# NOTE: Need to install the target and create export-set manually! CK
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed

# VERSION CK1.6.0
GIT_TAG 4ac95860ba72bb0eb324c4d63e35fb59be3bd50d
)
CPMAddPackage("gh:TheLartians/[email protected]")
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed

DISABLE_CHECK_REQUIRED_COMPONENTS YES
COMPATIBILITY SameMajorVersion
# XXX DISABLE_VERSION_SUFFIX NOT YET! CK
DISABLE_CHECK_REQUIRED_COMPONENTS YES
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant