Roll protocol to r1144541

ChromeDevTools · May 16, 2023 · 81e97fb · 81e97fb
1 parent 3c6f201
commit 81e97fb
Show file tree

Hide file tree

Showing 7 changed files with 78 additions and 36 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,7 +1,34 @@
 
 
+## Roll protocol to r1144541 — _2023-05-16T04:27:03.000Z_
+######  Diff: [`3c6f201...2076e50`](https://github.com/ChromeDevTools/devtools-protocol/compare/`3c6f201...2076e50`)
+
+```diff
+@@ browser_protocol.pdl:919 @@ experimental domain Audits
+       # Whether to report WCAG AAA level issues. Default is false.
+       optional boolean reportAAA
+
+-  # Runs the form issues check for the target page. Found issues are reported
+-  # using Audits.issueAdded event.
+-  command checkFormsIssues
+-    returns
+-      array of GenericIssueDetails formIssues
+-
+   event issueAdded
+     parameters
+       InspectorIssue issue
+@@ -950,8 +944,6 @@ experimental domain Autofill
+     parameters
+       # Identifies a field that serves as an anchor for autofill.
+       DOM.BackendNodeId fieldId
+-      # Identifies the frame that field belongs to.
+-      optional Page.FrameId frameId
+       # Credit card information to fill out the form. Credit card data is not saved.
+       CreditCard card
+```
+
 ## Roll protocol to r1143632 — _2023-05-13T04:26:23.000Z_
-######  Diff: [`53a0f38...a551954`](https://github.com/ChromeDevTools/devtools-protocol/compare/`53a0f38...a551954`)
+######  Diff: [`53a0f38...3c6f201`](https://github.com/ChromeDevTools/devtools-protocol/compare/`53a0f38...3c6f201`)
 
 ```diff
 @@ browser_protocol.pdl:10996 @@ experimental domain Preload
@@ -10257,38 +10284,4 @@ index bd277eb..09c420e 100644
    type RequestStage extends string
      enum
        Request
-```
-
-## Roll protocol to r884484 — _2021-05-19T15:16:15.000Z_
-######  Diff: [`f8d7e27...dfcf9be`](https://github.com/ChromeDevTools/devtools-protocol/compare/`f8d7e27...dfcf9be`)
-
-```diff
-@@ browser_protocol.pdl:746 @@ experimental domain Audits
-       Page.FrameId frameId
-       Network.LoaderId loaderId
-
--  type NavigatorUserAgentIssueDetails extends object
--    properties
--      string url
--      optional SourceCodeLocation location
--
-   # A unique identifier for the type of issue. Each type may use one of the
-   # optional fields in InspectorIssueDetails to convey more specific
-   # information about the kind of issue.
-@@ -767,7 +762,6 @@ experimental domain Audits
-       CorsIssue
-       AttributionReportingIssue
-       QuirksModeIssue
--      NavigatorUserAgentIssue
-
-   # This struct holds a list of optional fields with additional information
-   # specific to the kind of issue. When adding a new issue code, please also
-@@ -785,7 +779,6 @@ experimental domain Audits
-       optional CorsIssueDetails corsIssueDetails
-       optional AttributionReportingIssueDetails attributionReportingIssueDetails
-       optional QuirksModeIssueDetails quirksModeIssueDetails
--      optional NavigatorUserAgentIssueDetails navigatorUserAgentIssueDetails
-
-   # An inspector issue reported from the back-end.
-   type InspectorIssue extends object
 ```
diff --git a/json/browser_protocol.json b/json/browser_protocol.json
@@ -1852,6 +1852,19 @@
                             "type": "boolean"
                         }
                     ]
+                },
+                {
+                    "name": "checkFormsIssues",
+                    "description": "Runs the form issues check for the target page. Found issues are reported\nusing Audits.issueAdded event.",
+                    "returns": [
+                        {
+                            "name": "formIssues",
+                            "type": "array",
+                            "items": {
+                                "$ref": "GenericIssueDetails"
+                            }
+                        }
+                    ]
                 }
             ],
             "events": [
@@ -1913,6 +1926,12 @@
                             "description": "Identifies a field that serves as an anchor for autofill.",
                             "$ref": "DOM.BackendNodeId"
                         },
+                        {
+                            "name": "frameId",
+                            "description": "Identifies the frame that field belongs to.",
+                            "optional": true,
+                            "$ref": "Page.FrameId"
+                        },
                         {
                             "name": "card",
                             "description": "Credit card information to fill out the form. Credit card data is not saved.",

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "devtools-protocol",
-  "version": "0.0.1143632",
+  "version": "0.0.1144541",
   "description": "The Chrome DevTools Protocol JSON",
   "repository": "https://github.com/ChromeDevTools/devtools-protocol",
   "author": "The Chromium Authors",

diff --git a/pdl/browser_protocol.pdl b/pdl/browser_protocol.pdl
@@ -919,6 +919,12 @@ experimental domain Audits
       # Whether to report WCAG AAA level issues. Default is false.
       optional boolean reportAAA
 
+  # Runs the form issues check for the target page. Found issues are reported
+  # using Audits.issueAdded event.
+  command checkFormsIssues
+    returns
+      array of GenericIssueDetails formIssues
+
   event issueAdded
     parameters
       InspectorIssue issue
@@ -944,6 +950,8 @@ experimental domain Autofill
     parameters
       # Identifies a field that serves as an anchor for autofill.
       DOM.BackendNodeId fieldId
+      # Identifies the frame that field belongs to.
+      optional Page.FrameId frameId
       # Credit card information to fill out the form. Credit card data is not saved.
       CreditCard card
 

diff --git a/types/protocol-mapping.d.ts b/types/protocol-mapping.d.ts
@@ -1459,6 +1459,14 @@ export namespace ProtocolMapping {
             paramsType: [Protocol.Audits.CheckContrastRequest?];
             returnType: void;
         };
+        /**
+         * Runs the form issues check for the target page. Found issues are reported
+         * using Audits.issueAdded event.
+         */
+        'Audits.checkFormsIssues': {
+            paramsType: [];
+            returnType: Protocol.Audits.CheckFormsIssuesResponse;
+        };
         /**
          * Trigger autofill on a form identified by the fieldId.
          * If the field and related form cannot be autofilled, returns an error.

diff --git a/types/protocol-proxy-api.d.ts b/types/protocol-proxy-api.d.ts
@@ -788,6 +788,12 @@ export namespace ProtocolProxyApi {
          */
         checkContrast(params: Protocol.Audits.CheckContrastRequest): Promise<void>;
 
+        /**
+         * Runs the form issues check for the target page. Found issues are reported
+         * using Audits.issueAdded event.
+         */
+        checkFormsIssues(): Promise<Protocol.Audits.CheckFormsIssuesResponse>;
+
         on(event: 'issueAdded', listener: (params: Protocol.Audits.IssueAddedEvent) => void): void;
 
     }

diff --git a/types/protocol.d.ts b/types/protocol.d.ts
@@ -3628,6 +3628,10 @@ export namespace Protocol {
             reportAAA?: boolean;
         }
 
+        export interface CheckFormsIssuesResponse {
+            formIssues: GenericIssueDetails[];
+        }
+
         export interface IssueAddedEvent {
             issue: InspectorIssue;
         }
@@ -3666,6 +3670,10 @@ export namespace Protocol {
              * Identifies a field that serves as an anchor for autofill.
              */
             fieldId: DOM.BackendNodeId;
+            /**
+             * Identifies the frame that field belongs to.
+             */
+            frameId?: Page.FrameId;
             /**
              * Credit card information to fill out the form. Credit card data is not saved.
              */