Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed batching completes before all responses are returned. #7832

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

michaelstaib
Copy link
Member

@michaelstaib michaelstaib commented Dec 16, 2024

Fixes #7739

@michaelstaib michaelstaib added the 🍒 cherry-pick Consider cherry-picking these changes into the previous major version. label Dec 16, 2024
@michaelstaib michaelstaib added this to the HC-14.3.0 milestone Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.36%. Comparing base (f3e7ff2) to head (5f3f7fc).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7832      +/-   ##
==========================================
+ Coverage   74.33%   74.36%   +0.03%     
==========================================
  Files        2871     2876       +5     
  Lines      149806   150051     +245     
  Branches    17417    17449      +32     
==========================================
+ Hits       111359   111591     +232     
+ Misses      32645    32641       -4     
- Partials     5802     5819      +17     
Flag Coverage Δ
unittests 74.36% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 8f854f7 into main Dec 16, 2024
103 checks passed
@michaelstaib michaelstaib deleted the mst/batching-fix branch December 16, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 cherry-pick Consider cherry-picking these changes into the previous major version. 🌶️ hot chocolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing part of the response when using batched queries
1 participant