Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a generic version of the ID descriptor method #7503

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Sep 24, 2024

Summary of the changes (Less than 80 chars)

  • Added a generic version of the ID descriptor method.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.89%. Comparing base (bc437c4) to head (f33fbe8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s/Types/Relay/Extensions/RelayIdFieldExtensions.cs 71.42% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7503   +/-   ##
=======================================
  Coverage   77.88%   77.89%           
=======================================
  Files        2826     2826           
  Lines      141987   142008   +21     
=======================================
+ Hits       110585   110614   +29     
+ Misses      31402    31394    -8     
Flag Coverage Δ
unittests 77.89% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 86a9c81 into main Sep 25, 2024
5 checks passed
@michaelstaib michaelstaib deleted the gai/add-generic-id-method branch September 25, 2024 15:35
michaelstaib pushed a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants